search

WICG / fenced-frame

Proposal for a strong boundary between a page and its embedded content
https://wicg.github.io/fenced-frame/
Other
124 stars 31 forks source link

Use spec-prod instead of a Makefile to build the spec. #51

Closed jyasskin closed 1 year ago

jyasskin commented 1 year ago

This generally produces better error messages than curl.

Preview | Diff

domfarolino commented 1 year ago

Looks like this PR deletes the Makefile? What is the preferred way to build the spec locally? (I'm not familiar with spec-prod)

jyasskin commented 1 year ago

I could undelete the Makefile if people are actively using it. I'd always install Bikeshed locally and run bikeshed or bikeshed watch.

domfarolino commented 1 year ago

Hmm, I think make remote is pretty useful for people that don't have bikeshed installed, plus we still have the Makefiles in many WHATWG specs (DOM, Fetch, URL, etc) so it seems like good practice to keep it around?

jyasskin commented 1 year ago

Works for me. I've restored it, with just the make ci target removed.

jyasskin commented 1 year ago

(Part of the reason the WHATWG specs have Makefiles is that they have the COMMIT-SHA text macro, so raw bikeshed invocations actually fail. But I'm still fine with having Makefiles if the people actively developing a spec want them.)