search

WICG / fenced-frame

Proposal for a strong boundary between a page and its embedded content
https://wicg.github.io/fenced-frame/
Other
123 stars 31 forks source link

Elaborate on event reporting #78

Closed gtanzer closed 1 year ago

gtanzer commented 1 year ago

Preview | Diff

domfarolino commented 1 year ago

Also just so I'm clear, it's https://pr-preview.s3.amazonaws.com/WICG/fenced-frame/pull/78.html#finalize-a-reporting-destination that will report an event that is finalized right after report an event early-returns when it encounters pending events, is that right? So if report an event is invoked when the reporting map's keys are lists we do nothing, and expect finalize a reporting destination to do the actual sending sometime later?

gtanzer commented 1 year ago

Also just so I'm clear, it's https://pr-preview.s3.amazonaws.com/WICG/fenced-frame/pull/78.html#finalize-a-reporting-destination that will report an event that is finalized right after report an event early-returns when it encounters pending events, is that right? So if report an event is invoked when the reporting map's keys are lists we do nothing, and expect finalize a reporting destination to do the actual sending sometime later?

Yes, that's right. That's also how the implementation works (see callsites of FencedFrameReporter::OnUrlMappingReady https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:content/browser/fenced_frame/fenced_frame_reporter.cc;drc=e0e0d24aaa54727dc0a8bc4b159ccdf80d3f5d8d;bpv=1;bpt=1;l=243)