Closed dway123 closed 3 years ago
Thanks for the review, @chasephillips!
Let's wait for @mgiuca to take a look as well before merging just in case, since this is a sizeable change. Also, @mgiuca please let me know if you'd generally like us to ask for your review on changes to this explainer in the future, or if you're ok with me just requesting review from @chasephillips or other folks. Thanks!
Thank you for the reviews, @mgiuca, @chasephillips, @fallaciousreasoning, and @mkruisselbrink!
(oops sorry, I realized I forgot to squash the commits when merging this PR, so the commit history is a bit spammed now...)
(oops sorry, I realized I forgot to squash the commits when merging this PR, so the commit history is a bit spammed now...)
Ah no problem. I've updated the repo settings to always require a squash-and-merge before landing a PR.
To help prepare for review, particularly internal cross-functional review.
A fairly large change, including: