search

WICG / file-system-access

Expose the file system on the user’s device, so Web apps can interoperate with the user’s native applications.
https://wicg.github.io/file-system-access/
Other
670 stars 66 forks source link

Fixup the example #231

Closed RReverser closed 2 years ago

RReverser commented 4 years ago

In #196 getFile and getDirectory were renamed to get*Handle variants, but the example got skipped and still used old methods. While at it, also updated it to use the new showOpenFilePicker method instead of the obsolete one.

Preview | Diff

Preview | Diff

mkruisselbrink commented 4 years ago

(closing and re-opening to trigger IPR hooks)

a-sully commented 2 years ago

Apologies, I saw that the PR updated a use of chooseFileSystemEntries (which has since been fixed) and assumed it was irrelevant. I now see that the getDirectory and getFile updates are still relevant

a-sully commented 2 years ago

I can approve this if you help resolve the merge conflicts

w3cbot commented 2 years ago

a-sully marked as non substantive for IPR from ash-nazg.

a-sully commented 2 years ago

Thanks for the fix!