WICG / file-system-access

Expose the file system on the user’s device, so Web apps can interoperate with the user’s native applications.
https://wicg.github.io/file-system-access/
Other
654 stars 65 forks source link

Editorial: Replace backticks with quotes in broken drag-and-drop example #424

Closed a-sully closed 1 year ago

a-sully commented 1 year ago

This was accidentally broken in #357


Preview | Diff

mkruisselbrink commented 1 year ago

I'm pretty sure the backticks are intentional? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

inexorabletash commented 1 year ago

Agreed w/ @mkruisselbrink - the backticks seem correct

(I'd just leave an emoji but I was tagged as a reviewer)

a-sully commented 1 year ago

https://wicg.github.io/file-system-access/#draganddrop-example is broken as-is (presumably because it's within an

tag?)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/inexorabletash"><img src="https://avatars.githubusercontent.com/u/771547?v=4" />inexorabletash</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Bikeshed was just updated to fix handling of ` in examples. Update and re-run bikeshed locally?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/a-sully"><img src="https://avatars.githubusercontent.com/u/77407429?v=4" />a-sully</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Ah I see. It works locally with backticks. Presumably <a href="https://wicg.github.io/file-system-access">https://wicg.github.io/file-system-access</a> will update eventually?... Or does it need some trigger (like some PR merging)?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/inexorabletash"><img src="https://avatars.githubusercontent.com/u/771547?v=4" />inexorabletash</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>And if that doesn't work, consider using backtick-backtick-backtick-js .... backtick-backtick-backtick instead of xmp</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/inexorabletash"><img src="https://avatars.githubusercontent.com/u/771547?v=4" />inexorabletash</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>I kicked off a re-run of the action. Should be fixed in a few minutes.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/a-sully"><img src="https://avatars.githubusercontent.com/u/77407429?v=4" />a-sully</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Awesome, thanks!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/inexorabletash"><img src="https://avatars.githubusercontent.com/u/771547?v=4" />inexorabletash</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hmmm, didn't seem to do it. I'll keep poking.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/inexorabletash"><img src="https://avatars.githubusercontent.com/u/771547?v=4" />inexorabletash</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Okay good now. Needed to rerun the <strong>CI</strong> action, which is a prerequisite and automatically triggers the <strong>pages-build-deployment</strong> action</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>