search

WICG / idle-detection

A proposal for an idle detection and notification API for the web
Other
68 stars 22 forks source link

Add fully active check in start() #52

Open shaseley opened 12 months ago

shaseley commented 12 months ago

Preview | Diff

shaseley commented 12 months ago

@reillyeon can you PTAL? This is follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/4810975.

A couple notes:

  1. IIUC this can be used on workers, so this checks that the object is a Window, but the test below does not check that -- probably a bug?
  2. The linked wpt is failing on wpt.fyi, but not in chrome with run_web_tests or run_wpt_tests. Running with wpt serve doesn't seem to include the testdriver-vendor.js file, so I'm not sure how to debug this -- do you happen to have any ideas?
reillyeon commented 11 months ago
  1. The linked wpt is failing on wpt.fyi, but not in chrome with run_web_tests or run_wpt_tests. Running with wpt serve doesn't seem to include the testdriver-vendor.js file, so I'm not sure how to debug this -- do you happen to have any ideas?

I'm not sure. I haven't tried running tests with wpt serve in a long time.