Sort keys in the reverse order of `code unit less than`

WICG / import-maps

How to control the behavior of JavaScript imports

https://html.spec.whatwg.org/multipage/webappapis.html#import-maps

Other

2.68k stars 69 forks source link

Sort keys in the reverse order of `code unit less than` #182

Closed hiroshige-g closed 4 years ago

hiroshige-g commented 4 years ago

Fixes #181.

Preview | Diff

marcoscaceres commented 4 years ago

@hiroshige-g please be sure to ping me once you've joined the group and I can click the magic buttons to unblock this. Thanks again!

hiroshige-g commented 4 years ago

@marcoscaceres Thanks for handling! It seems I'm now a WICG participant.

marcoscaceres commented 4 years ago

Ok, all green now. Good to merge!

hiroshige-g commented 4 years ago

unable to create a test that failed before this change and passed after it.

I think this is fine, because: In the reference implementation before this PR the sort order was if the length is greater, or equal and a greater code unit, not if the length is greater, or a greater code unit as specified, and thus the resolution results by the ref impl were already correct.