search

WICG / inert

Polyfill for the inert attribute and property.
Other
922 stars 79 forks source link

Move new InertManager inside property check #167

Closed timbomckay closed 3 years ago

timbomckay commented 3 years ago

new InertManager was executing every time the file was imported instead of creating the instance only when the inert property was missing. Moving into the prototype check has resolved the issue for us for the past couple of months.

Fixes #159 Fixes #163

timbomckay commented 3 years ago

Not sure if my commit is not structured appropriately or if it's just complaining that I'm an affiliated member. Let me know what I need to do to fix this.

w3cbot commented 3 years ago

robdodson marked as non substantive for IPR from ash-nazg.

robdodson commented 3 years ago

I think the Travis build is just flaking because one of the chrome instances disconnected on node 10 but it's not a big deal (all the same tests passed on node 8). We really need to update the test suite :P

robdodson commented 3 years ago

Thank you @timbomckay! Just published v3.1.1 to npm with this change.