search

WICG / ink-enhancement

Other
12 stars 11 forks source link

Discrepancy in InkPresenter API name between Chromium implementation, explainer and Spec #35

Open sahirv opened 2 months ago

sahirv commented 2 months ago

I see both DelegatedInkTrailPresenter and InkPresenter used. DelegatedInkTrailPresenter is used in the Chromium implementation as well as the proposed IDL in the readme and explainer. However, the spec uses InkPresenter. Should we rename InkPresenter to DelegatedInkTrailPresenter to make it in line with the explainer and impl?

The cons of changing the impl would be an intensive process to deprecate the current API and get web developers to use the new one. I don't think this API has been implemented in other browsers yet, so this approach seems to be the simpler one. As for the names themselves, I think DelegatedInkTrailPresenter makes more sense anyway as we delegate the rendering of the ink trail to the operating system or browser.

sahirv commented 2 months ago

I see this blurb in the readme:

"This proposal provides infrastructure for authors to request a DelegatedInkTrailPresenter interface from User Agents that support it. It is intentionally designed so that in the future, a generic InkPresenter interface could be introduced that DelegatedInkTrailPresenter would inherit from, providing greater extensibility."

Not sure if we should just leave as is, as I'm not aware of any other implementations for InkPresenter in the works.