WICG / layout-instability

A proposal for a Layout Instability specification
https://wicg.github.io/layout-instability/
Other
159 stars 27 forks source link

s/or/and/ in "greater of X or Y" expressions #54

Closed dholbert closed 4 years ago

dholbert commented 4 years ago

(apologies for the pedantry)

The spec has a few instances of "...the greater of X or Y"

Strictly speaking, that should say "and", not "or", I think.

Mathematically speaking:

Also, consistency-wise (and as a sanity-check on my instinct here): CSS specs do seem to say "the greatest of X and Y" (rather than "or"), when they use this sort of phrasing.

e.g.:

the greater of the number determined by the table-column elements and the number determined by the first row,

https://www.w3.org/TR/2011/PR-CSS2-20110412/tables.html

the greater of the resolved min-width, CAPMIN, and GRIDMIN.

https://www.w3.org/TR/css-tables-3/

the greater of the two applicable Membership fees (for "A" and "B").

https://www.w3.org/Consortium/membership-faq


Preview | Diff

yoavweiss commented 4 years ago

@dholbert - can you join the WICG to appease the IPR bots?

npm1 commented 4 years ago

This can probably also be marked as non-substantive though?

yoavweiss commented 4 years ago

Since this corrects the normative logic, I thought it might be considered "substantive", even if it's small changes that don't alter the original meaning.

npm1 commented 4 years ago

I would say it's a grammatical correction, not a logical one. But in any case we can hold on merging it until the author joins WICG.

dholbert commented 4 years ago

@dholbert - can you join the WICG to appease the IPR bots?

Joined (at https://www.w3.org/community/wicg/join ). Let me know if there are other steps that I need to take to appease/re-trigger the bot.

yoavweiss commented 4 years ago

I think @tantek needs to approve you joining. You may also need to link your GH account with your W3C one.

yoavweiss commented 4 years ago

And the IPR bots give you their blessing 🎉

dholbert commented 4 years ago

Thanks, everyone!