This PR writes out the last option mentioned in #32. LP2PReciever.ontransport is removed in favor of a LP2PQuicTransportListener object. This allows a QuicTransport to be created/accepted by both the LP2PReceiver and LP2PRequest. It also replaces the EventHandler with a ReadableStream as mentioned in #30.
Do we find this to be an improvement overall? The new code examples look reasonable to me. The downsides I see are:
LP2PQuicTransportListener is quite long.
You have to know about the LP2PQuicTransport and LP2PQuicTransportListener constructors in addition to LP2PReceiver and LP2PRequest.
There is a naming difference between LP2PReceiver and LP2PQuicTransportListener. However, that does reflect their different way of working.
One way to address these is to add shorthand helpers as existed in the original explainer, pseudo code example:
// Peer A
const listener = navigator.lp2p.listen( { /* ... */ } );
// Peer B
const transport = navigator.lp2p.connect( { /* ... */ } );
This PR writes out the last option mentioned in #32.
LP2PReciever.ontransportis removed in favor of aLP2PQuicTransportListenerobject. This allows a QuicTransport to be created/accepted by both theLP2PReceiverandLP2PRequest. It also replaces theEventHandlerwith aReadableStreamas mentioned in #30.Do we find this to be an improvement overall? The new code examples look reasonable to me. The downsides I see are:
LP2PQuicTransportListeneris quite long.LP2PQuicTransportandLP2PQuicTransportListenerconstructors in addition toLP2PReceiverandLP2PRequest.LP2PReceiverandLP2PQuicTransportListener. However, that does reflect their different way of working.One way to address these is to add shorthand helpers as existed in the original explainer, pseudo code example:
Preview | Diff