WICG / manifest-incubations

Before install prompt API for installing web applications
https://wicg.github.io/manifest-incubations/
Other
98 stars 30 forks source link

Add borderless mode spec #74

Closed sonkkeli closed 1 year ago

sonkkeli commented 1 year ago

Preview | Diff

dmurph commented 1 year ago

Looking at window-controls-overlay - that is a separate repository (which was one of the options we talked about). So options here:

  1. If we want to put the explainer & spec inside of the manifest-incubations, which seems fine, I would recommend putting the spec text in the existing manifest-incubations spec index.html, which defines the display mode, etc.
  2. If you want to keep the spec document separate, then in that case I would recommend creating a WICG repository exclusively for that display mode definition specification.

Unfortunately I'm not sure if having a nested spec html in this repo will work with the WICG infrastructure.

I don't think I have any major preference. @mgiuca do you?

mgiuca commented 1 year ago

Hi @sonkkeli

I think it doesn't matter too much, but I agree with Dan it should either be in the manifest-incubations index.html, or a separate repo (either way, that would allow previews and such to work properly, which they don't if you add a new file in this repo).

My preference would be to just have it here. I would also prefer if WCO moved here as well. The fewer separate spec documents the better IMO, to avoid the need for weird cross-referencing and concepts split across many documents. If something is very separable and experimental then it can go in its own thing, but if there are cross-referenced concepts between WCO and this, then I would prefer them to both be here.

sonkkeli commented 1 year ago

That sounds good to me. Meanwhile the WCO is in it's own repo, is it okay if I just reference e.g. the draggable regions etc. parts from there with a TODO and whenever that would be moved here, then those few references can be fixed?

sonkkeli commented 1 year ago

I made some edits on this now so that there's no separate borderless spec but just added the borderless things to the manifest-incubations.

sonkkeli commented 1 year ago

Hey @dmurph PTAL :)

sonkkeli commented 1 year ago

PTAL :)