search

WICG / manifest-incubations

Before install prompt API for installing web applications
https://wicg.github.io/manifest-incubations/
Other
99 stars 29 forks source link

Add tabbed mode spec #95

Closed mgiuca closed 6 months ago

mgiuca commented 7 months ago

Based on an earlier draft by @loubrett (Louise Brett).

Preview | Diff

mgiuca commented 7 months ago

@loubrett Ready for you to look now.

mgiuca commented 7 months ago

I just pushed a major rework. Still incomplete so don't re-review yet.

mgiuca commented 6 months ago

Hi @loubrett . This is finally ready for review. PTAL; note that you can preview it here.

mgiuca commented 6 months ago

@dmurph adding as editor. PTAL, thanks, and let me know if you want to discuss!

mgiuca commented 6 months ago

@dmurph @loubrett Finished responding to both of your reviews. Thanks for the insightful comments & meeting this morning.

See my comments above - I was not able to do literally what we discussed but I think I have captured the behaviour you wanted. PTAL.

mgiuca commented 6 months ago

LGTM, although nit: the display_mode link in the rendered text seems broken.

Thanks Dan.

Yes, I mentioned this to you in a chat: we need to wait until w3c/csswg-drafts#7306 gets pushed out to the editor's draft, and then it will automatically resolve itself (because the definition of "display mode" was moved from CSS mediaqueries-5 to Manifest; Manifest updated right away, CSS did not). I don't know when that will be; it was last updated in May 2022, coming up to two years...

Edit: filed an issue about this.