Closed mgiuca closed 6 months ago
@loubrett Ready for you to look now.
I just pushed a major rework. Still incomplete so don't re-review yet.
Hi @loubrett . This is finally ready for review. PTAL; note that you can preview it here.
@dmurph adding as editor. PTAL, thanks, and let me know if you want to discuss!
@dmurph @loubrett Finished responding to both of your reviews. Thanks for the insightful comments & meeting this morning.
See my comments above - I was not able to do literally what we discussed but I think I have captured the behaviour you wanted. PTAL.
LGTM, although nit: the display_mode link in the rendered text seems broken.
Thanks Dan.
Yes, I mentioned this to you in a chat: we need to wait until w3c/csswg-drafts#7306 gets pushed out to the editor's draft, and then it will automatically resolve itself (because the definition of "display mode" was moved from CSS mediaqueries-5 to Manifest; Manifest updated right away, CSS did not). I don't know when that will be; it was last updated in May 2022, coming up to two years...
Edit: filed an issue about this.
Based on an earlier draft by @loubrett (Louise Brett).
Preview | Diff