Fix all errors and warnings - Githubissues

WICG / manifest-incubations

Before install prompt API for installing web applications

https://wicg.github.io/manifest-incubations/

Other

98 stars 30 forks source link

Fix all errors and warnings #96

Closed mgiuca closed 5 months ago

mgiuca commented 5 months ago

Miscellaneous editorial pass over the document to fix errors and warnings.

Semi-major changes:

Added explicit algorithm calling all the processing steps defined in this spec.
Removed unused definitions of "Additional Window Controls" and "Isolated Web App". (Neither of these terms were referenced, and shouldn't be defined here anyway.)
Add prose invoking launch the new_note_url.
Fix all uses of "URL" to link to the URL spec instead of protocol_handlers.url.

Minor fixes:

Fix broken links to fs and web-app-launch specs.
Link to protocol_handlers.
Protocol handlers algorithm: use variables rather than definitions.
Properly define PromptResponseObject/userChoice.
Fix definition of onbeforeinstallprompt.

mgiuca commented 5 months ago

Hi @dmurph - PTAL.

Note that this PR is based on #94. Both of these combined should put the spec into a much better state for editing in the future.