"subscribe to an": use |observer| instead of [=this=]

WICG / observable

Observable API proposal

https://wicg.github.io/observable/

Other

575 stars 14 forks source link

"subscribe to an": use |observer| instead of [=this=] #163

Closed keithamus closed 2 months ago

keithamus commented 2 months ago

The "subscribe to an" algorithm references [=this=] which I believe is likely due to it being refactored from a method to an independant algorithm. It should use |observable|, referencing the given observable, which is otherwise not mentioned in the algorithm.

Preview | Diff

keithamus commented 2 months ago

Oh I'm mistaken here. [=this=] is actually proper here.