search

WICG / observable

Observable API proposal
https://wicg.github.io/observable/
Other
563 stars 13 forks source link

Fix `finally` to return `Observable` #49

Closed benlesh closed 6 months ago

benlesh commented 11 months ago

closes #48

:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on Jan 30, 2024, 2:24 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2FWICG%2Fobservable%2F5b136db3304f7c0cb9b6c354a903953d273c75e2%2Fspec.bs&md-warning=not%20ready) _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20WICG/observable%2349.)._
domfarolino commented 11 months ago

I think just a tiny bit of documentation to make this slightly more clear (https://github.com/WICG/observable/pull/49#discussion_r1327094796) and resolving the conflicts is all that's needed for this at this point.

domfarolino commented 10 months ago

Ping

benlesh commented 9 months ago

@domfarolino updated the documentation about it

domfarolino commented 8 months ago

It looks like this will need to be rebased on top of the changes that ripped the IDL out of the README and into the spec.

benlesh commented 8 months ago

Rebased.

domfarolino commented 7 months ago

I can't seem to get your attention on https://github.com/WICG/observable/pull/49#discussion_r1412254718 so let me mention it directly here :)