search

WICG / observable

Observable API proposal
https://wicg.github.io/observable/
Other
563 stars 13 forks source link

Be careful not to over-claim in "Userland libraries" #8

Closed domenic closed 1 year ago

domenic commented 1 year ago

I believe several of the "observable" implementations listed, don't conform to the observable contract referenced. It would be good to separate out the ones that do, from the ones that are vaguely in a similar conceptual area. The former give support directly to the proposed design in the explainer; the latter just tell us that this is a problem area worth solving, but perhaps with a completely different API.

domenic commented 1 year ago

16 seems unrelated to this?

domfarolino commented 1 year ago

Yes thanks, I mixed #4 and this one up in the "Fixes"/"Closes" thingy.

benlesh commented 1 year ago

RxJS, tRPC, Apollo GraphQL, and Relay have nearly identical copies of Observable that match.

The others vary in similarity. TanStacks react-query has one that’s very very close.

benlesh commented 1 year ago

Here's PR to address this: https://github.com/domfarolino/observable/pull/23

(I forgot to put the issue # in the commit messages, sorry).

domfarolino commented 1 year ago

@benlesh Thanks a lot for the PR. Do you think we're OK to close this given your updated prose?

benlesh commented 1 year ago

Yeah.