search

WICG / private-network-access

https://wicg.github.io/private-network-access/
Other
52 stars 21 forks source link

Check Access-Control-Allow-Private-Network earlier #90

Closed jub0bs closed 1 year ago

jub0bs commented 1 year ago

This fixes issue #86.

w3cbot commented 1 year ago

jub0bs marked as non substantive for IPR from ash-nazg.

w3cbot commented 1 year ago

jub0bs marked as substantive for IPR from ash-nazg.

w3cbot commented 1 year ago

jub0bs marked as non substantive for IPR from ash-nazg.

jub0bs commented 1 year ago

I'm noticing now that the generated index.html has more changes seemingly unrelated to my changes to index.src.html and I'm at a loss to explain them... Sorry, I'm not very familiar with bikeshed.

letitz commented 1 year ago

Hi there, sorry for the long wait - I was out for next to 2 months and left a bit earlier than anticipated.

Thanks for running make. It seems that something to do with [=request/policy container=] has changed since I last built index.html. I'll look into rebuilding and pushing an updated index.html over which you can rebase your PR cleanly.

letitz commented 1 year ago

Hmm, it seems that it had not been rebuilt after #72, but that does not explain the rest of the changes. Can you rebase and try again? If that does not work, I'll check out your PR, run make, and update the PR myself.

jub0bs commented 1 year ago

@letitz Sorry for not getting back to you. I somehow missed your reply. I'll do as you suggested at some stage later today.

letitz commented 1 year ago

Thanks! Let me know how it goes.

jub0bs commented 1 year ago

That didn't work. I've still got what appears to be spurious changes.

FYI, I used bikeshed (3.11.4). I noticed that the latest index.html was generated with an older version of bikeshed. Perhaps bikeshed's behaviour has changed in the interim. Not too sure...

letitz commented 1 year ago

Alright, thanks for trying! I'll amend the PR myself, and look into updating bikeshed :eyes:

letitz commented 1 year ago

Fixed, thanks for your contribution!

FWIW, I don't think your branch was rebased on top of the latest main, maybe that was the issue?

jub0bs commented 1 year ago

@letitz I thought I did rebase. Oh well, it's done now. Thanks!

By the way, is there a crbug associated to this change?

letitz commented 1 year ago

Maybe the issue was differing versions of bikeshed? Hopefully that's improved by 250f177cc5585fb18b4bfa0c20f7c07ebd79ce71

Otherwise, I just filed crbug.com/1424847.