search

WICG / private-network-access

https://wicg.github.io/private-network-access/
Other
57 stars 22 forks source link

Rename private to local #97

Closed johnathan79717 closed 1 year ago

johnathan79717 commented 1 year ago

Fixes #91

yoavweiss commented 1 year ago

Hey @johnathan79717 - can you join the WICG to appease the IPR bots? :)

johnathan79717 commented 1 year ago

Ah right. I requested to join WICG just now.

I have kept the header names the same until we decide what to do with it. I'll probably need to modify the explainers if we're gonna go through with this. Did I miss anything else?

annevk commented 1 year ago

Please file explicit follow-up issues for things that are not renamed since you plan on closing the initial issue once this lands.

johnathan79717 commented 1 year ago

Please file explicit follow-up issues for things that are not renamed since you plan on closing the initial issue once this lands.

Good point. I removed the keyword in the description so it should not close the initial issue now.

johnathan79717 commented 1 year ago

Closing this as we decided against renaming. See https://github.com/WICG/local-network-access/pull/97

johnathan79717 commented 1 year ago

Reopening this PR since renaming is back on the table.

letitz commented 1 year ago

Let me know when this is ready for review.

johnathan79717 commented 1 year ago

Let me know when this is ready for review.

It is ready for review. 😄

letitz commented 1 year ago

Perfect! I shall start reviewing then :)