search

WICG / scroll-to-text-fragment

Proposal to allow specifying a text snippet in a URL fragment
Other
589 stars 42 forks source link

Consider renaming textFragmentToken #178

Closed annevk closed 1 year ago

annevk commented 2 years ago

Token typically does not mean a boolean in the web platform. At least in my experience. "Capability" might be more appropriate.

bokand commented 2 years ago

I don't feel strongly about "token" so renaming it to be more inline with the rest of the platform and maybe more descriptive sgtm.

How about simply allowTextFragment? Or more accurately (since we can still safely highlight when this is false), allowTextFragmentScrolling?

annevk commented 2 years ago

Thanks, either of those works for me as well.

annevk commented 1 year ago

I missed the PR, but this might need a couple further tweaks. But that can also happen as part of integrating this into Fetch/HTML. We try to stay away from "flag" these days and most Fetch/HTML concepts have names that are space-separated rather than camel cased.

bokand commented 1 year ago

Thanks - I'm trying to get the spec into shape for upstreaming here first so I'll put up a PR to fix it later today. If you don't mind I'll add you as a reviewer.

annevk commented 1 year ago

Sounds good, I can probably tackle that tomorrow. (After that it'll be Jan 2.)

bokand commented 1 year ago

Re-opening this to make sure you can take another look post-holidays.

annevk commented 1 year ago

Thanks, I think this looks good.