search

WICG / scroll-to-text-fragment

Proposal to allow specifying a text snippet in a URL fragment
Other
589 stars 42 forks source link

Need to specify setting start offset to zero #188

Closed megangardner closed 2 years ago

megangardner commented 2 years ago

in the description of the "To find a string in range" subroutine, we have these two parallel steps:

If curNode is part of a non-searchable subtree: If curNode is not a visible text node:

In the first it is not explicitly stated that the start offset needs to be set to zero. It does explicitly say that in the second step. It should say that start offset needs to be set to zero in both steps.

bokand commented 2 years ago

Yup, thanks for catching it. Will fix.