search

WICG / scroll-to-text-fragment

Proposal to allow specifying a text snippet in a URL fragment
Other
589 stars 42 forks source link

[Spec] Fix naming of textFragmentActivationFlag #203

Closed bokand closed 1 year ago

bokand commented 1 year ago

As per #178, spec text now typically uses space-separated names and "flag" is discouraged so this PR fixes #202 by changing textFragmentActivationFlag to text fragment activation and allowTextFragmentDirective to allow text fragment directive and fixes up some surrounding prose.

Fixes #178

Preview | Diff

bokand commented 1 year ago

@annevk - I can't add you as a reviewer but PTAL.

annevk commented 1 year ago

(To give better feedback I probably need to reread the document, but that'll have to wait until after the holidays.)

bokand commented 1 year ago

(To give better feedback I probably need to reread the document, but that'll have to wait until after the holidays.)

No worries - it'll hopefully be in better shape by then. Enjoy the holiday break!

bokand commented 1 year ago

Since I'm doing lots of work here, I'm going to go ahead and merge what I've got to avoid merge headaches, but happy to take more feedback when you return (and of course, it'll go through further review when upstreaming).