[Spec] Overhaul directive parsing - Githubissues

WICG / scroll-to-text-fragment

Proposal to allow specifying a text snippet in a URL fragment

Other

586 stars 43 forks source link

[Spec] Overhaul directive parsing #247

Closed bokand closed 8 months ago

bokand commented 8 months ago

Specify parsing imperatively

Add imperative steps to check validity and perform parsing
Make parsing happen earlier in the process so that we pass around parsed Text Directive objects rather than strings.
Make the steps more precise, referring to infra types and correctly decoding the strings.

Fixes #221 Fixes #230

Fix and make grammar non-normative

The grammar is now provided solely as a convenience and is non-normative.
Make UnknownDirective not subsumed by TextDirective.

Fixes #220

bokand commented 8 months ago

@annevk Similarly in this case, please let me know if you'd like me to change anything but otherwise I'll leave the review until the PR in HTML.