Add zh-cn translation (was: Fixed an anchor and corrected a typo.)

WICG / shape-detection-api

Detection of shapes (faces, QR codes) in images

https://wicg.github.io/shape-detection-api

Other

304 stars 35 forks source link

Add zh-cn translation (was: Fixed an anchor and corrected a typo.) #22

Closed neotan closed 7 years ago

neotan commented 7 years ago

Updated in index.bs file, instead of index.html

marcoscaceres commented 7 years ago

You are a hero, @neotan. Sorry you had to do extra work!

neotan commented 7 years ago

Never mind, @marcoscaceres. And thanks @miguelao for your straightforward guidance of W3C CSS Spec Preprocessor, it really help me out.

Btw, I am considering to introduce this spec to Chinese developer, i.e. translating into Chinese and provide a index-zh-cn.bs, do you guys think it's proper?

neotan commented 7 years ago

I just downloaded Chrome Canary(Version 58.0.3021.1 canary SyzyASan) and enabled chrome://flags/#enable-experimental-web-platform-features flag already. But sample1 and sample2 don't work now.

May I know is there any change at detection API level? Any code need to be adjust? Many thanks.

yellowdoge commented 7 years ago

@neotan, re.

the first example: s/faces[i].x/faces[i].boundingBox.x/ etc, that'll do the trick
the second example: oblique QR codes do not work well in Mac, try in Android, or another easier case such as, e.g. this one ?
the chinese translation: absolutely! I wonder how can we make evident in the Spec that you're the one in charge of such translation (like having a specific entry in the .bs), and how to keep it in sync with the english one, @marcoscaceres , any savvy tips here?

neotan commented 7 years ago

Hi @miguelao and @marcoscaceres , I just committed a Chinese version (dbceb8a). Kindly pls have a check is there anything I can improve. Many thanks.

marcoscaceres commented 7 years ago

@neotan, it looks good to me (though sadly I don't read Chinese).

neotan commented 7 years ago

@marcoscaceres ,hah~ believe me, I spent few hours to make this Chinese be perfect.

I'm already push the update to the repo of my fork, is it good to merge/accpet at your side now? Sorry, I am newbee to git.

marcoscaceres commented 7 years ago

@neotan, as I'm not the Editor of the spec, I will leave it for @miguelao to merge.

neotan commented 7 years ago

Understood @marcoscaceres . thx.

Btw, I am writing a news for introducing the these features to Chinese developers, want to attach this spec's english and chinese version to the news as references.

Do you guys think is it good? I mean, may I have your consent? @miguelao

yellowdoge commented 7 years ago

Oh, re.

Do you guys think is it good? I mean, may I have your consent? @miguelao

By all means go ahead :smile:: whatever is in this repo is of public access.

neotan commented 7 years ago

The news is posted at infoQ.com(China) now: http://www.infoq.com/cn/news/2017/03/chrome-shape-detection Thank you all!

marcoscaceres commented 7 years ago

Thank you for helping push the spec forward and getting the word out!

marcoscaceres commented 7 years ago

@neotan getting a 404 on that link, btw

yellowdoge commented 7 years ago

I got a 404 as well.

neotan commented 7 years ago

Opps~ the website just adjusted the URL: http://www.infoq.com/cn/news/2017/03/Chrome-Shape-Detection-API