search

WICG / shared-storage

Explainer for proposed web platform Shared Storage API
Other
85 stars 18 forks source link

Update spec for enrollment #105

Closed shivanigithub closed 10 months ago

shivanigithub commented 11 months ago

Update spec for enrollment

Preview | Diff

pythagoraskitty commented 11 months ago

Couldn't figure out how to reply inline to your comment above, @xyaoinum, i.e.

There seems to be two issues:

  1. In this spec, we only check the user settings during storage getters/setters, but not for addModule()/selectURL()/run(). We should check the user settings for those as well.
  2. In the spec, the Error is always "TypeError". In the code, the error type is sometimes OperationError. I can send a patch to fix (1) to unblock this patch (or @shivanigithub do you prefer doing the fix along with this patch?). And problem 2 can be addressed separately as it's not only relevant to user setting errors.

Anyway, I just approved and merged your fix to (1.)

As for (2.), that's due to feedback from my spec mentor, @wanderview, who had recommended that we not delve too deeply into categorizing various exceptions and just use TypeErrors. But I'm happy to revisit that.

wanderview commented 11 months ago

As for (2.), that's due to feedback from my spec mentor, @wanderview, who had recommended that we not delve too deeply into categorizing various exceptions and just use TypeErrors. But I'm happy to revisit that.

Maybe the solution is to fix the code to throw TypeError to be in sync with the spec?