search

WICG / shared-storage

Explainer for proposed web platform Shared Storage API
Other
85 stars 18 forks source link

Update spec.bs to address additional feedback #85

Closed pythagoraskitty closed 11 months ago

pythagoraskitty commented 1 year ago

We iterate on the spec based on further feedback in issues: 81, 83, 88, 89, 90, 91.

Preview | Diff

pythagoraskitty commented 1 year ago

@domfarolino @wanderview PTAL when you can. Thank you!

pythagoraskitty commented 1 year ago

Preview here

pythagoraskitty commented 1 year ago

@alexmturner, can you please take a look also when you get a chance, to see if these changes fix the issues you raised? Thanks

pythagoraskitty commented 12 months ago

Realized that the promises weren't being properly rejected when Shared Storage is disabled, so I've fixed that it my latest commit.

Still have several comments to address and some related issues that have since been opened. These are in my queue.

Preview here (Reposting from above)

pythagoraskitty commented 11 months ago

I still have some outstanding comments to address. I will open a new PR shortly in order to do so, but I need to land this now for logistical reasons.

domfarolino commented 11 months ago

Can you re-open any issues that may have been closed prematurely by the merge, given your last comment?

pythagoraskitty commented 11 months ago

Yes, definitely will do! Although it might be a day or so before I get to it. Will try to do it this week.