search

WICG / trust-token-api

Trust Token API
https://wicg.github.io/trust-token-api/
Other
419 stars 84 forks source link

Add permission policy checks #239

Closed aykutbulut closed 1 year ago

aykutbulut commented 1 year ago

Add permission policy feature definitions.

Update the Request constructor with policy checks in Modifications to request section.

Preview | Diff

aykutbulut commented 1 year ago

I get the same error (copied below for convenience) with my local bikeshed installation. I am not sure why it can not find reference for "should request be allowed to use feature". It is defined in the following section https://www.w3.org/TR/permissions-policy/#algo-should-request-be-allowed-to-use-feature

LINE ~455: No 'dfn' refs found for 'should request be allowed to use feature'.
[=should request be allowed to use feature=]
jyasskin commented 1 year ago

It's got data-dfn-type="abstract-op", and it ends with a "?", so you have to use [$Should request be allowed to use feature?$]. Sorry.

aykutbulut commented 1 year ago

Thanks for the tip. Fixed the reference. Added throwing NotAllowedError Dom exception before aborting the constructor steps.

Tried to add a custom text for the algorithm link and failed. Any ideas on how to fix that part?