Closed morlovich closed 6 months ago
@xtlsheep would appreciate if you could take a look at this
If this is just a refactor I am tempted to say I don't need to look at this and we can proceed with @xtlsheep's LGTM unless there is some specific stuff you'd like me to review. Does that sound OK?
If this is just a refactor I am tempted to say I don't need to look at this and we can proceed with @xtlsheep's LGTM unless there is some specific stuff you'd like me to review. Does that sound OK?
It's not completely mechanical (there is also some bugfix), but at any rate I would especially appreciate if you checked my map get syntax on line 1680, there is a high chance it's wrong.
OK I've mostly looked at the changes I was asked specifically to look at (and quickly scanned the others). If @xtlsheep is OK with this change then I think we can land it.
Yeah the change LGTM
@caraitto So this ended up having a rather non-trivial merge with updateIfOlderThanMs, so I would appreciate if you could take a look.
On Thu, May 16, 2024 at 2:16 PM caraitto @.***> wrote:
@.**** commented on this pull request.
In spec.bs https://github.com/WICG/turtledove/pull/1163#discussion_r1603845315:
@@ -1721,8 +1680,13 @@ To generate and score bids given an [=auction config=] |auctionConfig
- Let |directFromSellerSignalsForBuyer| be the result of running [=get direct from seller signals for a buyer=] with |directFromSellerSignals|, and |ig|'s [=interest group/owner=].
- Let |dataVersion| be |trustedBiddingSignalsBatcher|'s [=trusted bidding signals batcher/data versions=]
- [|ig|'s [=interest group/name=]].
- If |dataVersion| is not null, then [=map/set=] |browserSignals|["{{BiddingBrowserSignals/dataVersion}}"] to |dataVersion|.
Also, did @domfarolino https://github.com/domfarolino sign off?
On the pre-merge-with-your-stuff version.
Message ID: @.***>
...to separate struct + routines, since it's a non-trivial piece of code in the middle of a complicated algorithm, and I am about to make it a bit more complicated still.
Also fix a bug in data-version handling: If different data versions are returned during the various fetches, route them to the appropriate IG rather than using the last version for everything.
Preview | Diff