WICG / turtledove

TURTLEDOVE
https://wicg.github.io/turtledove/
Other
511 stars 215 forks source link

adSize not accepted as sizeGroup #1181

Closed laurb9 closed 1 month ago

laurb9 commented 1 month ago

With the example groups from the FLEDGE.md doc the following error happens on joinAdInterestGroup:

TypeError: Failed to execute 'joinAdInterestGroup' on 'Navigator': ads[1].sizeGroup 'size3' for AuctionAdInterestGroup with owner 'https://dsp.test' and name 'test-group' The assigned size group does not exist in sizeGroups map.

The doc says it should work:

Each named ad size is also considered a size group, so you don't need to manually define singleton size groups; for example see the sizeGroup: 'size3' code above.

Chrome Version 125.0.6422.41 (Official Build) beta (x86_64) Chromium Version 126.0.6471.0 (Developer Build) (x86_64)

Complete reformatted error message

failed to join interest group {
  "owner":"https://dsp.test",
  "name":"test-group",

 "biddingLogicURL":"https://dsp.test/buyer/test.js",
  "trustedBiddingSignalsURL":"https://dsp.test/tbs",
  "trustedBiddingSignalsSlotSizeMode":"slot-size",
  "ads":[
    {"renderURL":"https://dsp.test/ad/ad1.html","sizeGroup":"group1"},
    {"renderURL":"https://dsp.test/ad/ad2.html","sizeGroup":"size3"}],
  "adSizes":{
    "size1":{"width":"100","height":"100"},
    "size2":{"width":"100","height":"200"},
    "size3":{"width":"75","height":"25"},
    "size4":{"width":"100","height":"25"}},
  "sizeGroups":{
    "group1":["size1","size2","size3"],
    "group2":["size3","size4"]}}
TypeError: Failed to execute 'joinAdInterestGroup' on 'Navigator': ads[1].sizeGroup 'size3' for AuctionAdInterestGroup with owner 'https://dsp.test' and name 'test-group' 
The assigned size group does not exist in sizeGroups map.
shivanigithub commented 1 month ago

/cc @gtanzer

laurb9 commented 1 month ago

Actually the above is the wrong example, let me reproduce the one with the actual error in the subject

dmdabbs commented 1 month ago

It will apparently get support in the future according to this #970 comment:

laurb9 commented 1 month ago

Closing as dupe of #970 thanks @dmdabbs