search

WICG / turtledove

TURTLEDOVE
https://wicg.github.io/turtledove/
Other
538 stars 237 forks source link

[Spec] `perSlotSizeQueryParam` isn't initialized #1184

Open caraitto opened 6 months ago

caraitto commented 6 months ago

In the spec, perSlotSizeQueryParam never gets initialized.

Also, this line looks suspect: https://wicg.github.io/turtledove/#:~:text=Let%20perSlotSizeQueryParam%20be%20perBuyerGenerator%5BsignalsUrl

It's assigning a dictionary to another dictionary with different types. (That wouldn't compile if this were C++)

caraitto commented 6 months ago

Here's a permalink to the suspect line in source: https://github.com/WICG/turtledove/blob/c69e08cf2576c1d7981b6c7e4f2ccde334806ea2/spec.bs#L1422

caraitto commented 6 months ago

@MattMenke2