WICG / turtledove

TURTLEDOVE
https://wicg.github.io/turtledove/
Other
538 stars 237 forks source link

Spec: dataVersion argument to "Score and rank a bid" is often missing. #1234

Open MattMenke2 opened 3 months ago

MattMenke2 commented 3 months ago

There are 4 calls to score and rank a bid (2 for component auctions, 1 for additional bids, 1 for bids generated by the same level auction). The first 3 calls appear to be missing a dataVersion parameter - they go from null to auctionLevel. I believe the null is the "directFromSellerSignalsForSeller" parameter, not a null dataVersion. It's possible I'm wrong, and they're actually missing the "directFromSellerSignalsForSeller" parameter. The previous parameter in all calls is "decisionLogicFetcher", so it's definitely one of those two that's missing.