WICG / turtledove

TURTLEDOVE
https://wicg.github.io/turtledove/
Other
528 stars 232 forks source link

Bidding Logic script: 'url' field is mandatory #1290

Open fliccione opened 3 weeks ago

fliccione commented 3 weeks ago

Hi, we're facing the following situation: in the generateBid function, there is a scenario where we bid with -1 and the render URL is undefined. This indicates that we don't want to participate in the FLEDGE auction, for example, when none of the bids meet capping or frequency rules. However, we encountered the following error in the console:

Worklet error: https://interest-group-owner.com/biddingLogicScript.js generateBid() 'render': Required field 'url' is undefined.

Is it possible to make the render URL optional if the bid value is -1?

Thanks in advance

morlovich commented 3 weeks ago

The 'render' itself is optional (but if you include an object render, it must have a 'url').

So something like: return {bid: -1} is fine.

but: render {bid: -1, render:{}} is not.

This IDL may be of some use: https://wicg.github.io/turtledove/#dictdef-adrender

On Tue, Oct 1, 2024 at 11:05 AM fliccione @.***> wrote:

Hi, we're facing the following situation: in the generateBid function, there is a scenario where we bid with -1 and the render URL is undefined. This indicates that we don't want to participate in the FLEDGE auction, for example, when none of the bids meet capping or frequency rules. However, we encountered the following error in the console:

Worklet error: https://interest-group-owner.com/biddingLogicScript.js generateBid() 'render': Required field 'url' is undefined.

Is it possible to make the render URL optional if the bid value is -1?

Thanks in advance

— Reply to this email directly, view it on GitHub https://github.com/WICG/turtledove/issues/1290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4XKREMMDPFYVPTNL2RV43ZZK2Z7AVCNFSM6AAAAABPFZLWZ2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TSNJRGQYDEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MattMenke2 commented 3 weeks ago

It may make sense here to be a little more user friendly, and not display an error on "return {}" or "return <number<=0>", and instead just treat those as no bid.

morlovich commented 3 weeks ago

return {} should work as well, as would return undefined or return null. No magic conversion for bare doubles here, though (unlike scoreAd...)

On Tue, Oct 1, 2024 at 3:38 PM Matt Menke @.***> wrote:

It may make sense here to be a little more user friendly, and not display an error on "return {}" or "return <number<=0>", and instead just treat those as no bid.

— Reply to this email directly, view it on GitHub https://github.com/WICG/turtledove/issues/1290#issuecomment-2386844737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4XKRBGQUMH4GFQ7OFKYZTZZL2ZVAVCNFSM6AAAAABPFZLWZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWHA2DINZTG4 . You are receiving this because you commented.Message ID: @.***>