WICG / turtledove

TURTLEDOVE
https://wicg.github.io/turtledove/
Other
520 stars 222 forks source link

Soliciting feedback: Consider removing topLevelSellerSignals #821

Open brusshamilton opened 11 months ago

brusshamilton commented 11 months ago

The topLevelSellerSignals are returned from the top-level auction's reportResult function and are provided to the winning component seller's reportResult function.

Does anyone plan to use these signals? If so, can you describe your use case?

For the Bidding and Auction Services feature, where auctions are run in a trusted server environment instead of on device, passing the result from the top-level auction into the component auction will likely require an extra RPC (as otherwise they could speculatively run reporting and return the results with the component auction winner). So for auctions on trusted servers, removing this feature (or even just passing in an empty object "{}" for this field) would simplify implementation and improve performance. This is important for Bidding and Auction Services auctions since reporting worklets run before the auction returns, so they are on the critical path.

MattMenke2 commented 10 months ago

These were not added due to any specific request from a consumer, but rather to make multi-seller auctions more closely mirror single-seller auctions, with the winning component seller getting buyer-like signals from the top-level seller, so I don't think we have any signals from anyone that these are actually useful in practice.

rashmijrao commented 2 months ago

Since we have not received any more feedback and it was been 6 months. Can this issue be closed?