search

WICG / ua-client-hints

Wouldn't it be nice if `User-Agent` was a (set of) client hints?
https://wicg.github.io/ua-client-hints/
Other
590 stars 77 forks source link

Fixes #309 - Don't start or end a greaseyBrand w/ a greaseyChar #310

Closed miketaylr closed 2 years ago

miketaylr commented 2 years ago

Implementation experience has taught us that starting a brand w/ certain characters causes breakage (likely from firewalls). To be conservative, we prevent starting or ending with those.

:boom: Error: 400 Bad Request :boom:

PR Preview failed to build. (Last tried on Jun 28, 2022, 8:54 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2FWICG%2Fua-client-hints%2Ffb52ee6a9022d346d6a45d4fc6ab92a926951076%2Findex.bs&md-warning=not%20ready) ``` Error running preprocessor, returned code: 2. FATAL ERROR: Obsolete biblio ref: [rfc7231] is replaced by [rfc9110]. Either update the reference, or use [rfc7231 obsolete] if this is an intentionally-obsolete reference. ✘ Did not generate, due to fatal errors ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20WICG/ua-client-hints%23310.)._
miketaylr commented 2 years ago

Can you review @mreichhoff?

miketaylr commented 2 years ago

@mreichhoff ready for round 2

miketaylr commented 2 years ago

Thanks @mreichhoff!