search

WICG / ua-client-hints

Wouldn't it be nice if `User-Agent` was a (set of) client hints?
https://wicg.github.io/ua-client-hints/
Other
591 stars 77 forks source link

Use "Automotive" instead of "Automobile" #339

Closed miketaylr closed 1 year ago

miketaylr commented 1 year ago

This has the advantage of not match against poorly written regular expressions that are looking for "mobile" (probably not a real risk, but might as well change it before it becomes a problem).

Preview | Diff

miketaylr commented 1 year ago

PTAL @arichiv

arichiv commented 1 year ago

I dunno I kind of dig it

arichiv commented 1 year ago

Unrelated, but can I be given write access? Looks like I can’t merge here

miketaylr commented 1 year ago

Unrelated, but can I be given write access? Looks like I can’t merge here

Hm, I thought I did that... let me double check.

miketaylr commented 1 year ago
Screenshot 2023-04-02 at 11 50 50 AM

I gave you "Maintain" access, which according to https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization - you should be able to merge a PR...