Why is the name "form factor" (singular) instead of "form factors" or "form factor list"?

WICG / ua-client-hints

Wouldn't it be nice if `User-Agent` was a (set of) client hints?

https://wicg.github.io/ua-client-hints/

Other

583 stars 74 forks source link

Why is the name "form factor" (singular) instead of "form factors" or "form factor list"? #355

Closed domenic closed 6 months ago

domenic commented 6 months ago

Before adding form factor, the spec had two list-valued fields:

Sec-CH-UA-Full-Version-List HTTP header / fullVersionList JS API
Sec-CH-UA HTTP header / brands JS API

Introducing form factor creates a third list field, but it follows neither of the previous two precedents. Instead it uses the singular name "form factor".

Is this perhaps an oversight when working on #343, you forgot to consider renaming?

miketaylr commented 6 months ago

Is this perhaps an oversight when working on #343, you forgot to consider renaming?

Yeah, oops. @djmitche - any thoughts or preferences?

djmitche commented 6 months ago

If you look at it just right, the set of identifies describes the device's form-factor. But I agree, consistency with other hints would be good. So I guess that would mean Sec-CH-UA-Form-Factors and formFactors for JS.

miketaylr commented 6 months ago

I guess that would mean Sec-CH-UA-Form-Factors and formFactors for JS.

The shorter the better...

djmitche commented 6 months ago

I'll work on making this change in Chromium. If one of you can assign this issue to me it will make sure I don't forget to update it.

dmdabbs commented 6 months ago

Will you post to this issue the final disposition for the hint and/or to the tracking bug?

djmitche commented 6 months ago

I'll also update the draft spec in this repo, and the PR to do so will link here. I'm not sure what you mean by "final disposition", though.

dmdabbs commented 6 months ago

I'll also update the draft spec in this repo, and the PR to do so will link here.

The feature card (https://chromestatus.com/feature/5162545698045952) would probably also need a name change.

I'm not sure what you mean by "final disposition", though.

From the thread here the final naming did not seem settled.

miketaylr commented 6 months ago

To be clear, we will rename to Sec-CH-UA-Form-Factors, etc.

djmitche commented 6 months ago

https://issues.chromium.org/u/1/issues/328490271 for the updates in Chrome

miketaylr commented 6 months ago

Given https://github.com/WICG/ua-client-hints/pull/358 - I think we can close here. Thanks for the input @domenic!