Closed domenic closed 6 months ago
Is this perhaps an oversight when working on #343, you forgot to consider renaming?
Yeah, oops. @djmitche - any thoughts or preferences?
If you look at it just right, the set of identifies describes the device's form-factor. But I agree, consistency with other hints would be good. So I guess that would mean Sec-CH-UA-Form-Factors
and formFactors
for JS.
I guess that would mean
Sec-CH-UA-Form-Factors
andformFactors
for JS.
The shorter the better...
I'll work on making this change in Chromium. If one of you can assign this issue to me it will make sure I don't forget to update it.
Will you post to this issue the final disposition for the hint and/or to the tracking bug?
I'll also update the draft spec in this repo, and the PR to do so will link here. I'm not sure what you mean by "final disposition", though.
I'll also update the draft spec in this repo, and the PR to do so will link here.
The feature card (https://chromestatus.com/feature/5162545698045952) would probably also need a name change.
I'm not sure what you mean by "final disposition", though.
From the thread here the final naming did not seem settled.
To be clear, we will rename to Sec-CH-UA-Form-Factors
, etc.
https://issues.chromium.org/u/1/issues/328490271 for the updates in Chrome
Given https://github.com/WICG/ua-client-hints/pull/358 - I think we can close here. Thanks for the input @domenic!
Before adding form factor, the spec had two list-valued fields:
Sec-CH-UA-Full-Version-List
HTTP header /fullVersionList
JS APISec-CH-UA
HTTP header /brands
JS APIIntroducing form factor creates a third list field, but it follows neither of the previous two precedents. Instead it uses the singular name "form factor".
Is this perhaps an oversight when working on #343, you forgot to consider renaming?