Consistently use .mjs to denote modules

WICG / virtual-scroller

Other

2k stars 83 forks source link

Consistently use .mjs to denote modules #126

Closed mathiasbynens closed 5 years ago

mathiasbynens commented 6 years ago

Module scripts behave differently than classic scripts. As such, I'd like to suggest explicitly denoting the difference by using the .mjs extension for modules and .js for classic scripts.

More details on this guidance: https://developers.google.com/web/fundamentals/primers/modules#mjs

Similar changes have landed upstream in the Layered APIs repository. It would be nice to be consistent with that.

domenic commented 6 years ago

Readme line endings changed?

mathiasbynens commented 6 years ago

They were CRLF for some reason. The patch makes them LF which is consistent with the other files.

domenic commented 6 years ago

Can you separate that out into a separate commit, so that we can see the actual change?

abdonrd commented 6 years ago

@domenic you can use the Hide whitespace changes option from the GitHub diff settings:

domenic commented 6 years ago

I'm aware.

mathiasbynens commented 6 years ago

@domenic Done. (I ran unix2dos README.md and amended the commit.)

domenic commented 5 years ago

Things keep changing in this repository, so I'll need to retarget this against the two new branches (see #155). Let me close this and commit directly to those, with you as the author.