search

WICG / virtual-scroller

Other
2k stars 83 forks source link

Make README an explainer #156

Closed rakina closed 5 years ago

rakina commented 5 years ago

Apologies in advance - there's more TODOs than content :) cc @domenic Feel free to add to/change various parts, I'll work more on it tomorrow.

domenic commented 5 years ago

@rakina I finally got a chance to work on this. Your review/fixes/additions would be appreciated!

I ran out of time before doing the "alternatives considered" section, but I think that's the only major piece left.

domenic commented 5 years ago

Your text looks great, thank you! And thanks also for your fixes to my writing. I added the final section, and expanded the "Constraints" section into "Constraints and effects" per your comments. And then I did another tweaking pass.

To me this looks ready to merge, although the conflict between virtual-scroller and virtual-content naming is starting to feel a bit weird. Maybe we could resolve that first, then merge? But I'm eager to see this land either way.

rakina commented 5 years ago

Thanks for the additions! Renamed everything to virtual-scroller. Also just realized I don't actually have write access. Can you merge this?

domenic commented 5 years ago

Oh, eek! @valdrinkoshi would you mind giving @rakina write access? We will work on getting this repo moved to WICG soon enough so it's not a hassle for you any more :)

valdrinkoshi commented 5 years ago

Done @rakina you should have received the invite for collaboration 👌