Demos don't actually work in other browsers

WICG / virtual-scroller

Other

2k stars 83 forks source link

Demos don't actually work in other browsers #180

Closed domenic closed 5 years ago

domenic commented 5 years ago

The use of private field syntax in particular causes them to break. It's probably worth just switching everything to underscores, since the demos are getting to be so effective at illustrating performance differences.

fergald commented 5 years ago

Firefox barfs on fields: SyntaxError: fields are not currently supported fps-display.mjs:22:2.

export class FpsDisplay extends HTMLElement {
  _lastTime = null;
  _fps;

fergald commented 5 years ago

@domenic can you check safari and edge for me?

domenic commented 5 years ago

Let's close this and reopen in fergald/virtual-scroller-demos as necessary.