search

WICG / virtual-scroller

Other
2k stars 83 forks source link

Remove default width #55

Closed valdrinkoshi closed 6 years ago

valdrinkoshi commented 6 years ago

Fixes #53 by removing the default width and leveraging the display: block behavior. We still require a default height.

Also, set width/height instead of max-width/max-height for distributed content, as we expect the children to occupy the full width of a vertical list, and full height of a horizontal list. For grid lists we expect each child to be sized.

valdrinkoshi commented 6 years ago

That change is for the distributed content - the virtual-list children - in particular we set width: 100% only when layout = vertical, and height: 100% when layout = horizontal

domenic commented 6 years ago

Ah right, my eyes skimmed over the ::slotted(*). Looks good then!!