Polyfill calculation of scale is incorrect

WICG / visual-viewport

A proposal to add explicit APIs to the Web for querying and setting the visual viewport

https://wicg.github.io/visual-viewport/

MIT License

177 stars 28 forks source link

Polyfill calculation of scale is incorrect #21

Closed ChumpChief closed 8 years ago

ChumpChief commented 8 years ago

outerWidth is not a safe property to use in polyfills since its value varies per each UA's browser chrome. This calculation is wrong on all non-maximized desktop browsers as a result.

bokand commented 8 years ago

Thanks, didn't realize outerWidth/Height includes the window shadow on Windows :P

Took a bit of ingenuity and hacks but I think the updated method if pretty robust.