search

WICG / visual-viewport

A proposal to add explicit APIs to the Web for querying and setting the visual viewport
https://wicg.github.io/visual-viewport/
MIT License
177 stars 28 forks source link

visualViewport should probably be [SameObject, Replaceable] #26

Closed zcorpan closed 8 years ago

zcorpan commented 8 years ago

New things on window typically need to be annotated with [Replaceable]. The attributes CSSOM View defines on window are, https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface

Also you could add [SameObject] to require that the same object is returned every time.

So

partial interface Window {
    [SameObject, Replaceable] readonly attribute VisualViewport visualViewport;
};
bokand commented 8 years ago

Thanks, fixed now.