search

WICG / web-app-launch

Web App Launch Handler
Other
75 stars 28 forks source link

Switch `_` for `-` in values #46

Closed tomayac closed 2 years ago

tomayac commented 2 years ago

The explainer was sometimes using - in property values where it should have used _.

tomayac commented 2 years ago

Actually, in https://github.com/WICG/sw-launch/issues/24 it is pointed out that the recommendation is to use dash-delimited values. I'm changing my PR accordingly to remove underscores.

fallaciousreasoning commented 2 years ago

I vaguely remember this explainer used _ to make it more consistent with other manifest fields (though my personal preference would be to use - too)

tomayac commented 2 years ago

Yeah, for keys, it’s definitely underscores, but for values, the TAG’s recommendation is dashes.

alancutter commented 2 years ago

That recommendation is for enumeration values e.g. new-client, I don't think the manifest field names count as enumeration values. This pull request is updating the example to {"route_to": "auto", "navigate-existing-client": "always"} where route_to and navigate-existing-client are inconsistent with each other.

tomayac commented 2 years ago

We're all good then. The consistency is now eventual! :-)