search

WICG / web-otp

phone number verification
https://wicg.github.io/web-otp/
Other
94 stars 36 forks source link

Editorial: [[DiscoverFromExternalSource]] uses same |options| name for two different variables #36

Open mkruisselbrink opened 4 years ago

mkruisselbrink commented 4 years ago

In step 2 in https://wicg.github.io/WebOTP/#sctn-discover-from-external-source you seem to re-assign |options| to be the OTPCredentialRequestOptions inside the CredentialRequestOptions object, however later in that algorithm you still use |options| to refer to the outer CredentialRequestOptions object. You should probably not use the same name for two different objects/variables.