WICG / webcomponents

Web Components specifications
Other
4.39k stars 376 forks source link

Respec errors #874

Open yoavweiss opened 4 years ago

yoavweiss commented 4 years ago
Duplicate definition(s) of 'import' at: 1.
Couldn't match "HTMLLinkElement" to anything in the document or in any other document cited in this specification: webidl. See how to cite to resolve the error at: 1.
Couldn't match "Document" to anything in the document or in any other document cited in this specification: webidl. See how to cite to resolve the error at: 1.
Couldn't match "custom element" to anything in the document or in any other document cited in this specification: custom-elements, webidl. See how to cite to resolve the error at: 1.

@marcoscaceres - can you take a look?

yoavweiss commented 4 years ago

It's particularly problematic that this no-longer-maintained spec breaks. Would be good to find a solution for "freezing" respec specs.

marcoscaceres commented 4 years ago

We can bind then to particular ReSpec versions (but they miss out on security updates, etc.). Alternatively, we can “freeze” them by exporting as HTML, and putting the raw ReSpec source file in a different branch.

domenic commented 4 years ago

What spec are you referring to? Can you provide a link?

marcoscaceres commented 4 years ago

Old import and shadow by the looks of it.

domenic commented 4 years ago

They seem readable to me. Fixing these errors wouldn't buy us anything.

marcoscaceres commented 4 years ago

True. I’m not sure what we should do here. Are those specs dead? Should we “gut” them?

domenic commented 4 years ago

I already gutted as much of shadow DOM as I could. We'll keep working on gutting the rest.

Imports can probably be totally removed, yeah.

domenic commented 4 years ago

Or we could just leave them with errors? Is there something I'm missing that makes fixing the errors urgent?

yoavweiss commented 4 years ago

Nothing here is urgent - I just stumbled upon them, saw errors and reported them. The underlying issue is that the current setup for respec specs requires constant maintenance, which is not great for maintained specs, but becomes a real problem for no-longer-maintained ones. If we can kill this spec, that's not a problem here. But there could be things we want to keep around (for historical purposes) and having their links breaks for no good reason is a shame.

yoavweiss commented 4 years ago

Also, apologies for not including a link in my initial report - it's https://w3c.github.io/webcomponents/spec/imports/