WICG / webmonetization

Proposed Web Monetization standard
https://webmonetization.org
Other
466 stars 152 forks source link

feat: visual redesign and removal of obsolete content #445

Closed huijing closed 2 months ago

huijing commented 8 months ago

Closes #444 Will also resolve #460

This will end up being a mega-PR where the home page is completely re-worked. Is currently a fork of @melissahenderson's working branch and will be constantly rebased as that branch is updated. Plans change. ¯\_(ツ)_/¯

Potential new chronology of events might be: 1. Launch of WM alpha extension 2. Add docs pages related to alpha, i.e. how to get set up with testnet, screenshots of how to configure extension (potentially in conjunction with home page update) 3. Update home page (this PR) 4. WM beta extension is available 5. mh branch gets published

For now, just send good thoughts.

Okay, we've changed plans yet again. This PR has been open for way too long, some people's infants have probably started walking by now. The long and short of it is, since @raducristianpopa has added 2 pages with the new design already, it highlighted the fact that the new design is ready and has been ready for months now. There is no reason to not roll it out. Therefore, we are separating the content rewrite from the redesign.

netlify[bot] commented 8 months ago

Deploy Preview for webmonetization-preview ready!

Name Link
Latest commit 8ea8494a52b291a6cb91d8270c29ac798cea1f8d
Latest deploy log https://app.netlify.com/sites/webmonetization-preview/deploys/66c46f4f1b7610000824cbc8
Deploy Preview https://deploy-preview-445--webmonetization-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JoblersTune commented 2 months ago

@huijing going through the new site I found this in src/components/pages/PrCta.astro

---
const { label } = Astro.props;
---
<div class="cta">
  <img class="iconMerge" src="/img/icon-merge.svg" alt="" />
  <p>
    Do you know another {label}?{" "}
    <a
      href="https://github.com/WICG/webmonetization/edit/main/docusaurus.config.js"
      target="_blank"
      rel="noreferrer noopener"
    >
      Make a PR
    </a>
  </p>
</div>

Shouldn't the link be: https://github.com/WICG/webmonetization/pulls

Perhaps we can just as well fix that here too.

JoblersTune commented 2 months ago

You mentioned fixing https://github.com/WICG/webmonetization/pull/460 but I still see image

JoblersTune commented 2 months ago

Also just wondering what happened to

  1. Linking the spec?
  2. Mentioning "Web Monetization Enabled Search Engines"
melissahenderson commented 2 months ago

Re "Web Monetization Enabled Search Engines": Mojeek's site appears to only have the meta tag, not the link tag. So I'm not sure we have any WM-enabled search engines at the moment.

JoblersTune commented 2 months ago

I realise this is also kind of out of scope of this PR but I'm also wondering if we have the correct link here? `

Web Monetization is being proposed as a W3C standard at <a href="https://github.com/WICG/webmonetization" rel="noreferrer noopener" target="_blank"

the Web Platform Incubator Community Group.

`

Shouldn't it rather be https://wicg.io/?