search

WICG / webmonetization

Proposed Web Monetization standard
https://webmonetization.org
Other
457 stars 153 forks source link

fix(spec): make bubbling clearer for `onmonetization` #458

Open sidvishnoi opened 3 months ago

sidvishnoi commented 3 months ago

Also removed duplicate content in head.

netlify[bot] commented 3 months ago

Deploy Preview for webmonetization-preview ready!

Name Link
Latest commit 3656f66665da2f0d5525aa9e04870b1d834c287e
Latest deploy log https://app.netlify.com/sites/webmonetization-preview/deploys/66716b5ad7806b0008322143
Deploy Preview https://deploy-preview-458--webmonetization-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

w3cbot commented 3 months ago

sidvishnoi marked as non substantive for IPR from ash-nazg.

sublimator commented 3 months ago

Won't somebody think of the grandchildren?

On Tue, 18 June 2024, 5:21 pm W3C Bot, @.***> wrote:

sidvishnoi https://github.com/sidvishnoi marked as non substantive for IPR from ash-nazg.

— Reply to this email directly, view it on GitHub https://github.com/WICG/webmonetization/pull/458#issuecomment-2175746375, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEAHG4PFGAFG4ZPMGOGVUDZIAC3HAVCNFSM6AAAAABJPXDWVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVG42DMMZXGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sidvishnoi commented 3 months ago

Was adding onmonetization to <body> while the <link> was in <head> (and I wasn't alone doing that),

sidvishnoi commented 3 months ago

Oh I need to generate specification manually? It's not in deploy preview.

sublimator commented 3 months ago

Won't somebody think of the respec job?

On Tue, 18 June 2024, 5:25 pm Sid Vishnoi, @.***> wrote:

Oh I need to generate specification manually? It's not in deploy preview.

— Reply to this email directly, view it on GitHub https://github.com/WICG/webmonetization/pull/458#issuecomment-2175754988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEAHG4KT5B5D2B5AOYXZS3ZIADJPAVCNFSM6AAAAABJPXDWVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVG42TIOJYHA . You are receiving this because you commented.Message ID: @.***>

sidvishnoi commented 3 months ago

I don't like adding that file to commit log. I'll do the CI first.