WING-NUS / SSID

Student Submission Integrity Diagnosis

18 stars 23 forks source link

Fix skeleton code handling + wrong comparison in PR #389 #400

Closed sibinhho99 closed 8 months ago

sibinhho99 commented 9 months ago

Description

This PR contains bug fixes for changes introduced in #389 .

I forgot to add the condition to exclude skeleton codes when getting the students' submissions for both current sem and past sems as described in

https://github.com/WING-NUS/SSID/blob/0fb4da9054d0148605f65cc050a426866e7dfb5a/lib/java/PlagiarismDetection/src/pd/SimComparer.java#L73

This causes error when skeleton code is supplied.

Also fixed the mistake mentioned in #401's description.

Related Issue

399

401

Motivation and Context

Bug fix

How Has This Been Tested?

Local testing with same Archive.zip file as in #399.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

coveralls commented 9 months ago

coverage: 4.204%. remained the same when pulling 4f388226f4c44562fe0cf20f10eceb7ff79af242 on sibinhho99:references_skeleton_fix into c6faa790b628269acce07c56240b81f85d7f493e on WING-NUS:master.