🐛 Wrong comparison when comparing submissions within current sem - Githubissues

WING-NUS / SSID

Student Submission Integrity Diagnosis

18 stars 23 forks source link

🐛 Wrong comparison when comparing submissions within current sem #401

Closed sibinhho99 closed 8 months ago

sibinhho99 commented 8 months ago

Cc:

Hi

Describe the Bug

This is a bug of the change introduced in #389 .

When submitting the Arhive.zip file in https://github.com/WING-NUS/SSID/issues/399, skeleton code is mysteriously included in current sem submissions' comparisons

This is because there's a careless mistake in the comparison in https://github.com/WING-NUS/SSID/blob/0fb4da9054d0148605f65cc050a426866e7dfb5a/lib/java/PlagiarismDetection/src/pd/SimComparer.java#L82C5-L82C5 , whereby the s2 submission should be from the currentSemSubmissions variable instead of submissions.

To Reproduce

Steps to reproduce the behavior:

Try to submit Archive.zip file in https://github.com/WING-NUS/SSID/issues/399
Error processing, printing out the processing results shows a "skeleton" student appearing in the comparison results.

Expected Behavior

Correct comparisons made

Tasks

[x] Investigate
[x] Fix

Acceptance Criteria

More Information

Environment

Device: [e.g. iPhone 12]
Browser: [e.g. chrome, safari]
OS: [e.g. iOS]

Screenshots

Thanks!