WINSDK / bite

Disassembler focused on comprehensive rust support.
MIT License
769 stars 24 forks source link

Default color MAGENTA is completely unreadable on grey background. #9

Closed AndreasOM closed 2 months ago

AndreasOM commented 2 months ago

I know you can change it in the config, but it would be nice if I could read the text on a vanilla startup.

Quick hack I did locally -- in tokenizing/src/lib.rs

    //pub const MAGENTA: Color = color!(0xf5, 0x12, 0x81);
    pub const MAGENTA: Color = color!(0xf5, 0x62, 0x81);
WINSDK commented 2 months ago

I'll get the colorscheme system to include all colored things in the GUI. When that's done it shouldn't be too hard to try making the text more readable.

WINSDK commented 2 months ago

Commits 2614c7a675ea0a78a9e2158265649851843b7c8f and 4e7dab4abd09e18dadc15d6386302bc947065c9b add more more options to the colorscheme for this kinda thing now. Changed the color in 67bf3ae45d0b3ae8463f56bd8b3c241d34ab2c36.

AndreasOM commented 2 months ago

Much better!

Thank you!